Fix TypeError: '>=' not supported between instances of 'str' and 'int' in msvs_emulation.py #5

critical-bug · 2021-05-05T14:31:46Z

Fixes a mere syntax problem.

When I build mozc, GYP gives the following error:

Traceback (most recent call last):
  File "C:\work\depot_tools\bootstrap-2@3_8_9_chromium_14_bin\python3\bin\lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "C:\work\depot_tools\bootstrap-2@3_8_9_chromium_14_bin\python3\bin\lib\multiprocessing\pool.py", line 48, in mapstar
    return list(map(*args))
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\generator\ninja.py", line 2467, in CallGenerateOutputForConfig
    GenerateOutputForConfig(target_list, target_dicts, data, params, config_name)
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\generator\ninja.py", line 2405, in GenerateOutputForConfig
    target = writer.WriteSpec(spec, config_name, generator_flags)
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\generator\ninja.py", line 484, in WriteSpec
    link_deps = self.WriteSources(
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\generator\ninja.py", line 923, in WriteSources
    return self.WriteSourcesForArch(
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\generator\ninja.py", line 946, in WriteSourcesForArch
    asmflags = self.msvs_settings.GetAsmflags(config_name)
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\msvs_emulation.py", line 436, in GetAsmflags
    config = self._TargetConfig(config)
  File "C:\work\mozc\src\third_party\gyp\pylib\gyp\msvs_emulation.py", line 324, in _TargetConfig
    if self.vs_version.short_name >= 2015:
TypeError: '>=' not supported between instances of 'str' and 'int'

google-cla · 2021-05-05T14:31:54Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-05-06T13:35:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Fix TypeError: '>=' not supported between instances of 'str' and 'int'

critical-bug force-pushed the patch-1 branch from 0f43d58 to e4e7530 Compare May 6, 2021 13:35

Update msvs_emulation.py

0a57ea6

Fix TypeError: '>=' not supported between instances of 'str' and 'int'

critical-bug force-pushed the patch-1 branch from e4e7530 to 0a57ea6 Compare May 6, 2021 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix TypeError: '>=' not supported between instances of 'str' and 'int' in msvs_emulation.py #5

Fix TypeError: '>=' not supported between instances of 'str' and 'int' in msvs_emulation.py #5

critical-bug commented May 5, 2021

google-cla bot commented May 5, 2021

google-cla bot commented May 6, 2021

Fix TypeError: '>=' not supported between instances of 'str' and 'int' in msvs_emulation.py #5

Are you sure you want to change the base?

Fix TypeError: '>=' not supported between instances of 'str' and 'int' in msvs_emulation.py #5

Conversation

critical-bug commented May 5, 2021

google-cla bot commented May 5, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented May 6, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers